clj-commons/metrics-clojure

code still uses com.codahale.metrics package name not io.dropwizard.metrics

jeffmad opened this issue · 5 comments

jeffmad commented

Maybe I am missing something, but if sjl/metrics-clojure is using 3.1 version of metrics now with the 2.6.0 release, then the package names should be (:import [io.dropwizard.metrics MetricRegistry]) not (:import [com.codahale.metrics MetricsRegistry])

(ns metrics.core
(:import [com.codahale.metrics MetricRegistry Metric]))

(def ^{:tag MetricRegistry :doc "Default registry used by public API functions when no explicit registry argument is given"}
default-registry
(MetricRegistry.))

(defn ^com.codahale.metrics.MetricRegistry new-registry
)

https://github.com/dropwizard/metrics/blob/master/metrics-core/src/main/java/io/dropwizard/metrics/MetricRegistry.java

michaelklishin commented

@jeffmad please submit a pull request.

jeffmad commented

will do.

michaelklishin commented

@jeffmad actually, in v3.1.2, package names are still com.codahale, so you are looking at master.

jeffmad commented

Michael, sorry for the confusion I caused.

michaelklishin commented

@jeffmad no worries, it's a good heads up for us: at some point we'll have to upgrade beyond 3.1.2 ;)