clj-commons/rewrite-clj

Add a library to README.

FiV0 opened this issue · 12 comments

FiV0 commented

I extracted mranderson's move ns a while ago into kusonga as I was always having dependency issues with it. Just added a couple of more functions. I mainly use it to rename projects. I just bumbed it to v1 of clj-rewrite, in case you want to add it to the readme. I can also do a PR if you accept it.

Yes please!

And great job, looks really useful.

lread commented

Awesome @FiV0!

i updated mranderson to v1 a while ago too btw, or am i missing the point here? ;)

lread commented

@benedekfazekas maybe?

@FiV0 extracted a feature out of mranderson to its own project.

oh got that too. obviously i like the idea benedekfazekas/mranderson#37

lread commented

Oh actually, @benedekfazekas I hadn't noticed you'd updated mranderson to rewrite-clj v1. Cool!
Thanks! I'll update the rewrite-clj README.

thanks @lread i wanted to let you know but apparently forgot. thanks for the awesome work btw. @FiV0 there are some changes in mranderson.move you might want to check if you care for such -- sorry for being offtopic

lread commented

Heya @FiV0, I'm updating libs in docs as I write this, I can handle this one for ya.

FiV0 commented

@benedekfazekas The main reason I extracted it was that mranderson requires leiningen dependencies. So if you just want to use the move namespace in a deps.edn project you also need to have leiningen on the classpath.

I abs. agree with that @FiV0 . i even had the same ideas, see benedekfazekas/mranderson#37 and benedekfazekas/mranderson#42 only never got around to implement them. that said now we have the classic problem of how to keep your fork uptodate and howto merge back relevant improvements from your fork into mranderson. I should just find the time to separate it out really. would you be open to create a series of PRs on such a project to add your improvements?

(again, sorry @lread for hijacking this issue for this discussion)

lread commented

(not a problem @benedekfazekas 🙂)