clojure-vim/clj-refactor.nvim

neovim api changes

snoe opened this issue · 4 comments

snoe commented

Thanks to @markwoodhall for pointing this out on slack. neovim api has changed in a seemingly non-compatible way around neovim/neovim@1c22cab (possibly earlier). I've raised an issue upstream with node-host to track this neovim/node-host#17 .

Until then, I'm guessing neovim/neovim@e968d72#diff-dbc90d97de125c32609c02bc24e2cabf should be a safe-ish build point unfortunately I don't have the bandwidth to do a full bisect of the issue.

We were careful to maintain backwards-compatibility. The nvim_ prefix is recommended and the old methods are deprecated but still supported. But if something broke, please let us know.

snoe commented

@justinmk it looks like neovim/node-client had been updated in neovim/node-client@c9725b3 which broke compatibility with neovim/node-host - that might be the only problem it's just getting hard to track these transitive dependencies

snoe commented

@markwoodhall upstream issues should be resolved, make sure to update node-host and deps in your nvim bundle dir. Please reach out if you're still having trouble running the plugin.

Thanks for investigating this, I started by updating node-host and now I've created my setup again from scratch. In both instances, when I open a clojure buffer I'm getting the message below:

screen shot 2016-10-05 at 08 08 05

If I ignore that and try to a run a cref to extract a function, after entering the function name and pressing enter I get the error below:

screen shot 2016-10-05 at 08 08 54

Having said that, I've tried a number of other operations that work fine now, for example cril, crml, cred.