Review unicode support
SevereOverfl0w opened this issue · 0 comments
SevereOverfl0w commented
Unicode support was added somewhat hastily. I pretty much just shoved a b in front of all the strings, and switched StringIO for BytesIO.
- I'm not entirely sure that StringIO is even used anymore. The import may be removable
- For some reason, StringIO can be imported as either
from StringIO import StringIOorfrom io import StringIO, what are their differences? does something similar apply to BytesIO? - This code the comment probably doesn't need to be there anymore and it should be split up to ensure that it's understood that it's doing two things:
nrepl-python-client/nrepl/bencode.py
Lines 106 to 109 in a97ba25
- Getting the length of the string in bytes
- Turning that length into a utf-8 encoded string
There's probably more refactoring to look into, but this is what comes to mind.