clonemeagain/attachment_preview

Printing Ticket does not print image or PDF

Opened this issue · 2 comments

Hi, I had never printed the ticket before, just tested and notice, images or PDF don't show up

I looked at this and it still does not work
9b5d0a6

update,
it works for images, should it work for.PDF files too? because it does not work for pdf files

include/class.pdf.php
change line: 42
from:
$self->{$key} = $file->getData();

To:
$self->imageVars[$key] = $file->getData();

include/mpdf/vendor/mpdf/mpdf/src/Config/ConfigVariables.php
line: 265
from:
'ignore_table_percents' => false,
'ignore_table_widths' => false,

To:
'ignore_table_percents' => true,
'ignore_table_widths' => true,

https://forum.osticket.com/d/93661-resolved-images-not-appearing-in-print/21

Were you expecting attachments to appear inside a printout?
Hmm, at this time, no, doesn't work that way. If you would like that feature, there are possible hacks we could make, but it doesn't look possible as a Plugin-only feature at the moment, and MOD's are a bit hackish.. and hard to maintain.

If you wanted to write it, and submit a PR, by all means!

You'd have to do something in the ticket-print.tmpl.php file, around:
https://github.com/osTicket/osTicket/blob/develop/include/staff/templates/ticket-print.tmpl.php#L240 to get it to insert them. Probably harder than I think..