cloud-gov/cg-diagrams

Diagrams for PRs should be viewable during review

Closed this issue · 3 comments

cnelson commented

When reviewing a PR the diagrams should be available for review along with the changes to the underlying code.

Possible Implementation Sketch

  • Concourse monitors for pull requests
  • Concourse generates diagrams for each PR and pushes to an s3 bucket
    • s3 bucket has a lifecycle policy to automatically nuke old content
  • Concourse updates PR with a link to the generated diagrams as a status check
afeld commented

This might be a good opportunity to (start to) think about per-branch deployments more broadly. @jseppi Was there an issue around that somewhere?

jseppi commented

@afeld: no, we don't have an issue about doing that. I don't think we (the CALC project) have enough cloud.gov quota to seriously consider doing it for all branches, though I could see doing it with develop, staging, and master branches.