cloudevents/sdk-java

2.4.0 breaks JSON Deserialization

fredoboulo opened this issue · 3 comments

Hi,

We can't update io.cloudevents:cloudevents-json-jackson:2.3.0 to 2.4.0.

Our cloudEvents have a datacontenttype with value application/json;charset=utf-8, which leads to JSON deserialization error.
The newly introduced Pattern in JsonFormat does not take parameters into account.

Reading the spec, it seems a bit confusing

Would it be possible to enrich the pattern to take the parameters into account?

Hi @fredoboulo, thanks for reporting!

I think it makes sense what you're suggesting.

cc @JemDay @segator

@fredoboulo since nobody raised any concern so far, can you contribute this change to the SDK?

Sorry for the delay guys I were on vacations with limited access to mail.
@pierDipi so the idea is to support in the regex attributes like the charset one

foo/barr;attr1=value&attr2=value... ?