cloudfoundry/bosh-cli

update-cloud-config does not offer the --named flag

friegger opened this issue · 6 comments

https://bosh.io/docs/cli-v2/#update-cloud-config does not support the --name flag. With this it cannot do everything that update-config can do. As mentioned in cloudfoundry/bosh#2209 (comment) this should actually be the case.

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/168946968

The labels on this github issue will be updated when the story is started.

Hey @friegger I agree we should probably add that. It does feel like a good idea so that update-runtime-config and update-cloud-config match. That being said, I don't think update-cloud-config does anything special, so in theory bosh update-config --name NAME --type cloud would achieve the exact same result.

I still see value in this change to help reduce surprises to operators, but not an urgent must have.

This issue was marked as Stale because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale label or comment below.

This issue was closed because it has been labeled Stale for 7 days without subsequent activity. Feel free to re-open this issue at any time by commenting below.

mvach commented

Hi I'm currently working on that issue.

The director part: https://github.com/cloudfoundry/bosh/tree/update-cloud-config-with-name-param
The cli part: https://github.com/cloudfoundry/bosh-cli/tree/update-cloud-config-with-name-param

I didn't create PRs so far, since there is some more testing that need to be done

mvach commented

I created following PRs: