error returned from SetGraceTime is ignored
Closed this issue · 3 comments
The garden server ignores the error form the SetGraceTime call:
https://github.com/cloudfoundry-incubator/garden/blob/master/server/request_handling.go#L867
Hi there!
We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.
The current status is as follows:
- #109274420 error returned from SetGraceTime is ignored
This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.
ah, yeah, I think the errors on SetGraceTime were added just in order to be able for garden to return an error to the client (we had to add the errors to both since the same interface is used for the client and the backend implementation of Container), we never envisaged the backend wanting to return an error from this (or from GraceTime, as you've noticed in #42). I'd be totally fine with a pull request that allowed the backend to return an error from these calls.