Make health-check-http-endpoint optional
Gourab1998 opened this issue · 5 comments
Gourab1998 commented
Why can health-check-http-endpoint not be optiional?
https://github.com/cloudfoundry-community/go-cfclient/blob/main/operation/manifest.go#L50
This is a problem for non "web" type processes since they should not have health-check-http-endpoint.
Please let me know if I am missing something
ckganesan commented
@Gourab1998 I believe this won't pose any problems for other types. The invocation of configuration by CF will depend on the type.
Gourab1998 commented
@ckganesan When I try to push a manifest of health check type "process" this is what cf controller returns
Also, ideally speaking we should not keep optional field as mandatory 😅
Gourab1998 commented
The example provided for push app here fails due to same error.