BIP 133: Support feefilter messages, and protocol version 70014
vincenzopalazzo opened this issue · 3 comments
From the test in my local machine of the PR #51 that increase the protocol version to 70014, the feefilter (BIP133) is included in the protocol version
As the debug log shows
2021-09-29T13:57:52.306+02:00 DEBUG nakamoto_p2p::protocol 78.98.15.147:8333: Received "feefilter"
2021-09-29T13:57:52.306+02:00 DEBUG nakamoto_p2p::protocol::channel Received unknown feefilter from peer 78.98.15.147:8333
2021-09-29T13:57:52.306+02:00 DEBUG nakamoto_p2p::protocol::channel 78.98.15.147:8333: Sending "unknown"
2021-09-29T13:57:52.370+02:00 DEBUG nakamoto_p2p::protocol 78.98.15.147:8333: Received "pong"
2021-09-29T13:57:53.257+02:00 DEBUG nakamoto_p2p::protocol 97.120.18.239:8333: Received "addr
I think it is easy to support it in nakamoto, if you like I can take care of this issue if the #51 will be merge.
What would adding support for feefilter mean for nakamoto? I'm not really sure there is any benefit in supporting it as a light-client.
What would adding support for feefilter mean for nakamoto? I'm not really sure there is any benefit in supporting it as a light-client.
Mh, this is a good question, that I'm not able to answer, right now. I will close this issue, and maybe reopen it in the future for a future discussion.
Thanks!
Sounds good!