cloudposse/geodesic

Move All Helmfile Values Inline

Closed this issue · 4 comments

what

  • Use inline values

why

  • More concise format
  • Does not require external file
  • Does not require YAML-selectors

example

- rbac:
create: {{ env "KIAM_RBAC_CREATE" | default "false" }}
agent:
gatewayTimeoutCreation: "5s"
host:
interface: "cali+"
nodeSelector:
kubernetes.io/role: "node"
tolerations:
- operator: "Exists"
tlsFiles:
### Required: KIAM_AGENT_TLS_CA; e.g. base64-encoded ca.pem
ca: '{{ env "KIAM_AGENT_TLS_CA" }}'
### Required: KIAM_AGENT_TLS_CERT; e.g. base64-encoded agent.pem
cert: '{{ env "KIAM_AGENT_TLS_CERT" }}'
### Required: KIAM_AGENT_TLS_KEY; e.g. base64-encoded agent-key.pem
key: '{{ env "KIAM_AGENT_TLS_KEY" }}'
server:
gatewayTimeoutCreation: "5s"
nodeSelector:
kubernetes.io/role: "master"
tolerations:
- key: "node-role.kubernetes.io/master"
effect: "NoSchedule"
operator: "Exists"
extraHostPathMounts:
- name: "ssl-certs"
mountPath: "/etc/ssl/certs"
hostPath: '{{ env "KIAM_HOST_CERT_PATH" | default "/etc/ssl/certs" }}'
readOnly: true
tlsFiles:
### Required: KIAM_AGENT_TLS_CA; e.g. base64-encoded ca.pem
ca: '{{ env "KIAM_SERVER_TLS_CA" }}'
### Required: KIAM_SERVER_TLS_CERT; e.g. base64-encoded server.pem
cert: '{{ env "KIAM_SERVER_TLS_CERT" }}'
### Required: KIAM_SERVER_TLS_KEY; e.g. base64-encoded server-key.pem
key: '{{ env "KIAM_SERVER_TLS_KEY" }}'

Let's first implement #157

Should i also refactor set with inline values?
It will be more standardized this way.

Is this done now?