cloudposse/terraform-aws-tfstate-backend

Add delete_protection to DynamoDB table

gw0 opened this issue · 3 comments

gw0 commented

Describe the Feature

This TF module has a force_destroy variable that can prevent accidental S3 bucket deletions. The DynamoDB table also supports a similar flag deletion_protection_enabled that prevents accidental deletions.

Because the purpose is the same, I would suggest reusing the variable also for this case by adding the following into the aws_dynamodb_table:

deletion_protection_enabled = !var.force_destroy

Expected Behavior

DynamoDB deletion_protection_enabled should also be enabled by default.

Use Case

Prevent accidental deletions.

Describe Ideal Solution

deletion_protection_enabled = !var.force_destroy

Alternatives Considered

No response

Additional Context

No response

Reporting same problem.
If Dynamo table will not be destroyed some-were in middle of destroy but as last one, that will also work.

Any update on this issue? Run into a problem every time testing that the table gets deleted which also gets rid of the lock file.

should be fixed.