Improve aria markup to satisfy WAVE accessibility tests

Question

Improve aria markup to satisfy WAVE accessibility tests

Closed this issue 3 months ago · 8 comments

At present the use of role="menubar" in the views is invalid unless you (at least) also state role="menuitem" for each nav link within the bar.

Probably wants a bit more consideration than just that, to make sure these really are at all useful under aria.

Needs changes in Bootstrap4TopNavWithDropdowns and possibly a few others
_LoginPartialWithDropdowns (main cs Core repo)
Bs4ChildDropdown

Answer 1 · 2022-10-05T21:33:15.000Z

@JimKerslake could we resolve this one soon? I think role="menuitem" needs to be added to each link. This make a typical cloudscribe horizontal menu pass tests in WAVE, II've found.

Answer 2 · 2022-10-06T12:33:20.000Z

cloudscribe.web.navigation up to v6.0.1
but also need to chase this up the chain so it gets used by the template...

cloudscribe.Web.SiteMap.FromNavigation.6.0.1

cloudscribe.Core.Web 6.0.9

Answer 3 · 2023-02-16T16:33:50.000Z

Several more views needing the same, it turns out

Answer 4 · 2023-02-16T17:12:41.000Z

cloudscribe.Web.Navigation up to 6.0.2
cloudscribe.Web.SiteMap.FromNavigation up to 6.0.2

Going to need to push a new cloudscribe.Core.Web to deliver those...

Answer 5 · 2023-02-16T17:27:32.000Z

cloudscribe.Core.Web. 6.0.21

Answer 6 · 2024-05-16T09:25:06.000Z

@markidox to check and test this now passes a11y tests.

Answer 7 · 2024-05-17T07:43:12.000Z

According to WAVE there are no issues with the nav or dropdowns as things stand.

Answer 8 · 2024-05-17T07:51:52.000Z

Thanks @markidox sounds like we've successfully fixed all the issues, and can close this issue.