cloudscribe/cloudscribe.Web.Navigation

PreservedRouteParameters only preserved via query string

Closed this issue · 4 comments

I would like to use some RouteData values when generating the URLs so I tried using the PreservedRouteParameters attribute. Unfortunately, it currently only works with the query string, i.e. they are taken from the query string and put back there in the AdjustUrl method

public string AdjustUrl(TreeNode<NavigationNode> node)

It does not work in my case as the data is not the query string but in the RouteData and I don't want to put it back in the query string but in the URL itself (the values are part of the template).

I think this is do-able using the ActionContext.

What do you think? I can work on a PR if that's OK.

Hi,

We would be happy to review a PR to help the library meet your needs, but if it will be more than 10 lines of code we need a signed contributor agreement before we can review it.
https://raw.githubusercontent.com/cloudscribe/cloudscribe/master/copyright-assignment.txt

Thank you!

Happy to help!
I already have a working solution in my app, as a work-around. Putting it in the library won't be a problem, but probably a little over 10 lines of code.
I'll send the agreement via email and submit a PR tomorrow.

Unfortunately it will take a little bit more time that I anticipated as I need to loop in the legal department. I hope to be able to send you the signed agreement next week.

@dchaib thanks for sending over the contributor agreement. We're happy to review your PR when you're ready.