Memory leak in BufferedChannel writeMessage()

[netcarver]

Hi Christian,

Found a "memory leak" in my local server using this component and isolated it to this class+method. The memory usage keeps growing indefinitely as more messages are passed to the WriteMessage() method as it never trims its internal arrays (both the bufferedData and bufferedType arrays can grow indefinitely large.)

[SimonFrings]

@netcarver thanks for bringing this up! 👍

This was more of a design choice. If the connection would be interrupted for an amount of time and a message comes in right at that moment it would get lost without a buffer. This also applies to other clients connecting at different times. This way everyone can see every message, but you're right, it comes with a price.

There is the plan to add a limit at some point in the future, there's also a comment about it inside the writeMessage() function in BufferedChannel.php.

In the long run, our plan is to build similar support into Framework x.

[clue]

What @SimonFrings says ☝️ This project is currently more of a proof of concept to show how Server-Sent Events (SSE) can be used with @reactphp. We're working on a more permanent solution for X in the near future, so I don't think there's much to be done here at the moment 👍

I believe this has been answered, so I'm closing this for now. Please come back with more details if this problem persists and we can always reopen this 👍