Program doesn't close all the way using stop command
tomrhollis opened this issue · 2 comments
A very minor issue but it could mess with batch scripts.
OS: Windows
To reproduce:
- Execute vellum
- Wait for BDS to finish loading
- type "stop"
- Sticks on "vellum quit correctly" until user hits enter
If you type a command instead of enter, it throws an exception instead.
Can be fixed with one line, but not sure if/how it would affect Linux. See upcoming pull request. #14
Hey! Thanks a lot for reporting this issue and for your PR 🙂!
I just merged it into the development branch because I will work my way through the remaining pull requests today, and then merge everything into master and push a new release 🙂!
I remember also stumbling across this issue and thinking that probably there is also a "cleaner" way of exiting vellum instead of calling System.Environment.Exit(0); because if all resources are freed and the application reaches the bottom of the call stack, it should just quit, which let's me to believe there is probably still some thread(s) running when executing the stop command (probably the backupIntervalTimer and renderIntervalTimer timers?). But anyway, this will do for now and once again thank you very much for your pull request 🙂.
EDIT: I will leave this issue open until the new release is pushed 🙂.