cmgmyr/laravel-messenger

High CPU usage

ozgursoy opened this issue · 3 comments

ozgursoy commented

laravel-messenger/src/Models/Message.php

Line 104 in 8fa8d36

public function scopeUnreadForUser(Builder $query, $userId)

Thanks for package but, this query is some kind of nightmare for SQL, If you have millions of messages and user, the app will be fucked up. We can't use this query without caching.

cpy466 commented

laravel-messenger/src/Models/Message.php

Line 104 in 8fa8d36

public function scopeUnreadForUser(Builder $query, $userId)

Thanks for package but, this query is some kind of nightmare for SQL, If you have millions of messages and user, the app will be fucked up. We can't use this query without caching.

Don't bother using this package for real life apps. Take a look at $thread->creator()->name for example, your queries will duplicate to the sky if you have only 200 messages. Not to mention unread .. etc. Sorry guys but it is !

  • 👍1
cmgmyr commented

Thanks for the feedback. I realize there needs to be some performance improvements to the package. I haven't had the time lately to work through them. I'm sure with moving forward with the latest Laravel versions we could utilize newer features as well. Always happy to take a look at PRs 🙂

cpy466 commented

Thanks for the feedback. I realize there needs to be some performance improvements to the package. I haven't had the time lately to work through them. I'm sure with moving forward with the latest Laravel versions we could utilize newer features as well. Always happy to take a look at PRs 🙂

@cmgmyr Thank you. :)