cms-nanoAOD/nanoAOD-tools

Typo in JetReCalibrator.py?

kschweiger opened this issue · 1 comments

When running the jecUncertainties.py with self.redoJEC = True, the postprocessor crashes with

== CMSSW:   File "/srv/CMSSW_10_2_15/python/PhysicsTools/NanoAODTools/postprocessing/modules/jme/jetmetUncertainties.py", line 99, in __init__
== CMSSW:     self.jetReCalibrator = JetReCalibrator(globalTag, jetType , True, self.jesInputFilePath, calculateSeparateCorrections = False, calculateType1METCorrection  = False)
== CMSSW:   File "/srv/CMSSW_10_2_15/python/PhysicsTools/NanoAODTools/postprocessing/modules/jme/JetReCalibrator.py", line 45, in __init__
== CMSSW:     if self.calculateSeparateCorrections or self.calculateType1METCorrection:
== CMSSW: AttributeError: JetReCalibrator instance has no attribute 'calculateType1METCorrection'

It seems to me, that self.calculateType1METCorrectionhere should be self.calculateType1METCorr (see L19 in same file).

Can an expert on this code confirm this?

fgolf commented

Yes, this should be fixed by PR #185