cms-nanoAOD/nanoAOD-tools

UL case not covered in fatJetUncertaintiesProducer

nowaythatsok opened this issue · 3 comments

nowaythatsok commented

The first dict in jetmetHelperRun2.py seems to suggest that for UL datasets the correct dataYear parameter starts with UL. Subsequently, in fatJetUncertaintiesProducer this leads to a crash in this line ( UnboundLocalError: local variable 'jmstau21DDTNomVal' referenced before assignment ) as era strings starting with UL are not covered in the previous if statement.
I am tagging my colleague @bartokm so we can both follow this issue.

meisonlikesicecream commented

Also stumbled upon this issue, and wondering if you ever solved it? I can see the PR but it's still open after almost a year...

Currently I'm just doing it the ugly way and removing the UL substring in the following line: https://github.com/cms-nanoAOD/nanoAOD-tools/blob/master/python/postprocessing/modules/jme/fatJetUncertainties.py#L34

In other words: self.era = era.replace("UL", "")

bartokm commented

Hi,
That is one way to do it, but I think it's not optimal for future changes. What we did is the same as in this PR (which was never merged...):
https://github.com/cms-nanoAOD/nanoAOD-tools/pull/286/files

meisonlikesicecream commented

Hi, That is one way to do it, but I think it's not optimal for future changes. What we did is the same as in this PR (which was never merged...): https://github.com/cms-nanoAOD/nanoAOD-tools/pull/286/files

Definitely agree that's the better way to do it. Shame that the PR hasn't been merged :-(