cmu-db/bustub

bug: incorrect return type for ExtendibleHTableHeaderPage::GetDirectoryPageId

kenleung5e28 opened this issue · 1 comments

kenleung5e28 commented

The signature for ExtendibleHTableHeaderPage::GetDirectoryPageId is:

auto GetDirectoryPageId(uint32_t directory_idx) const -> uint32_t;

Judging from the intent for this method, its return type should be page_id_t instead.

lidianzhong commented

I think so, page_id_t type should be returned