Travis CI: use Docker in builds
dvanaken opened this issue · 6 comments
Update .travis.yml to run tests using our Docker images: https://github.com/cmu-db/ottertune/tree/master/docker
I'm not sure of the best way to do this but it seems like the following needs to happen:
- Test the code in the repo pointed to by $TRAVIS_BUILD_DIR instead of cloning the repo: https://github.com/cmu-db/ottertune/blob/master/docker/Dockerfile#L12
- Use docker-compose to run the same tests we run in our current version of .travis.yml: https://github.com/cmu-db/ottertune/blob/master/.travis.yml#L46
@dvanaken sure, I can take a stab at this. 👍
In fact, cloning the repo is not a best practice, but I left so that it didn't change very much from the previous Dockefile version.
@eribeiro @edwardoliveira It turns out I need this sooner than I thought so I'm working it now, but if you have time to review the PR tonight that would be helpful. I am planning to merge it tonight after I get #211 merged.
@dvanaken Hi, I have taken a first stab at using Docker for CI, but as you need this sooner (and I am reviewing a book for Manning whose deadline is tomorrow 😬 ), then you could take a look and see if there's anything worth including in your solution. Some tests are not passing and it is an incomplete solution, at best. Please, let me know what do you think. :)
@edwardoliveira Thanks for the head start! I will let you know when I submit a PR with the full changes.