Fix bug in graph editor where if you rename variable, its indicent edges disappear (but reappear if you close and reopen the graph editor)
jdramsey opened this issue · 6 comments
jdramsey commented
Fix bug in graph editor where if you rename variable, its indicent edges disappear (but reappear if you close and reopen the graph editor)
jdramsey commented
Fixed in branch.
cg09 commented
Thank you. Now if only we could draw edges from a graph box after renaming
variables. Maybe we can?
…On Fri, Sep 29, 2023 at 2:55 PM Joseph Ramsey ***@***.***> wrote:
Fixed in branch.
—
Reply to this email directly, view it on GitHub
<#1693 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD4Y3OLH4MXMFR7KD2Y4OHTX44KTVANCNFSM6AAAAAA5EPD55Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
jdramsey commented
Nope that doesn't work yet. I'll re-open this.
jdramsey commented
Sorry my brain's turned to jelly. I'll do this later.
jdramsey commented
That turned out to be trickier than I thought. Eventually, I realized how I had solved that before and did it. I need to think about it, though. Note to self: It turns out the code needs to identify graph nodes with the same name. If you use object-identity, the updaters break. The solution was if you have a null node in the edgeLists map, the thing to do is to reconstitute the map since a node of that name is already there and it just needs to be mapped properly.
jdramsey commented
Fixed in branch.