[Feature] Replace hardcoded timeouts with variables
Closed this issue · 5 comments
Problem:
- some of the tests contain hardcoded timeouts, it would be nice to have constants that timeout vs putting the number in the code
- ie. wait_count = 60
Possible solution:
- Replace hardcoded timeouts with variables
List of tests to replace hardcoded timeouts
- tbd, need to add to issue
- src/tasks/litmus_setup.cr
- src/tasks/chaos_mesh_setup.cr
- src/tasks/workload/resilience.cr
- src/tasks/workload/microservice.cr
- spec/workload/microservice_spec.cr
- spec/utils/utils_spec.cr
- spec/workload/statelessness_spec.cr
- spec/workload/resilience/network_chaos_spec.cr
- spec/utils/cnf_manager_spec.cr
- spec/workload/installability_spec.cr
How will this be tested
- Create a modified CNF that will exceed the time limits specified for the specific tests,
- Run workload tests
- I would expect the tests in question to fail if the wait_count is exceeded
- I would expect the tests in question to pass if the test finishes before the wait_count limit
@williscool please link to an example of a hardcoded timeout
Hello, @kosstennbl is this issue in progress?
kosstennbl added a commit to kosstennbl/cnf-testsuite that referenced this issue on Jan 31
@kosstennbl
WIP: https://github.com/cnti-testcatalog/testsuite/issues/335[: Change timeouts to constant variables](kosstennbl@54bbb52) …
54bbb52
Use constants with meaningfull names for defining timeouts
for different tasks and waiters. Where possible - unify
multiple values under one variable.
Signed-off-by: Konstantin Yarovoy konstantin.yarovoy@tietoevry.com
@lixuna
Hi, yes, I've left it behind for several months, but this week I've started again and It will probably be ready for review by Friday-Monday