Minor refractoring in labhub tests
nvzard opened this issue · 11 comments
Do minor changes in labhub_tests as asked here #572 (review) (see below)
difficulty/low
i am a beginner, can i help?
@ssg2526 you should get yourself assigned to a difficulty/newcomer issue which you understand. I set the difficulty of this issue as low but gitmate-bot missed it maybe :3
I think this issue would be a little tricky for a newcomer, but if you understand this you can get yourself assigned otherwise look for another newcomer issue :)
Specifically
self.assertEqual(self.labhub.TEAMS, self.teams)
This should use assertIs
instead of assertEqual
in test_invite_cmd
mock_dict['is_room_member'].return_value = True
it is already True, and this should be removed
Assigned. sorry we tend to respond better on gitter
@Makman2 @li-boxuan Please assign me this issue.