coatyio/vda-5050-lib.js

Paramterer inbount in topicObjectValidation in ClientOptions is not applied

Closed this issue · 1 comments

Hello,

Paramterer inbount in topicObjectValidation in ClientOptions is not applied.

The problem is in the AgvController constructor. In line 812 in file agv-controller.ts, where the parent constructor is called, the inbound value is hard-coded to false.

Hello,

This is by design! Inbound topic objects must not be validated by client (and dropped if invalid) as they are validated later when processing Order and InstantAction topics, responding with corresponding VDA 5050 error objects in State object (see _processOrder, _processInstantActions). If we were to validate topic objects in ctor by client, an invalid order or instant action would simply be dropped.