Latin and Vietnamese character issues
thangngoc89 opened this issue · 8 comments
There is one (so far) character in Vietnamese which was replace by the Latin one:
Đ => Dj
in Vietnamese, it should be Đ => D
Can you please also provide example word and its transliteration with this letter, so we can add it to tests so never ever again this issue will not appear again :)
It's is my name :)
Nguyễn Đăng Khoa
The slug should be nguyen-dang-khoa instead of nguyen-djang-khoa.
Đ character is populate in Vietnamese but it have some restriction.
Đ has to follow by vowels (a,u,e,i,o). But you should run these vowels through Slugify because in Vietnames, it can be in many forms: à á ẻ ị ỉ ,.......
creted pull requests, when it will be merged into code your name will be part of slugify :)
Yeah. Thanks you. That seem fine now. 👍
@mac2000 You commit would overwrite the current behaviour. I don't know of any (other) language that uses Đ. But is D the only valid transliteration? Or is there another valid transliteration for another language?
@mac2000 one problems here: Đ and Đ. They are 2 different ways to type that characte
Initial set of transliteration rules was copy pasted from Wikipedia and other sources, now language speaking people correcting wrong assumptions about what is correct way to transliterate symbols, so in my opinion there is nothing bad, and actually D seems to be more correct rather than Dj, and after all if there is other cases we can always create new issues and take decision what to do next
*feel free to cancel this PR if you are afraid of something
Thanks for the clarification.