code-423n4/2021-11-nested-findings

Unused local variables

Opened this issue 4 years ago · 2 comments

code423n4 commented 4 years ago

Handle

ye0lde

Vulnerability details

Impact

Removing the unused local variables improves code clarity.

Proof of Concept

Suggest changing to (uint256[] memory amounts,)
https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L379
https://github.com/code-423n4/2021-11-nested/blob/f646002b692ca5fa3631acfff87dda897541cf41/contracts/NestedFactory.sol#L410

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Remove the unused variables - See POC

maximebrugel commented 4 years ago

Duplicated #67 & #66

alcueca commented 4 years ago

Taking this as main.