Upgraded Q -> 2 from #308 [1685704892606]
Closed this issue · 2 comments
Judge has assessed an item in Issue #308 as 2 risk. The relevant finding follows:
[L-04] MIN_NONZERO_TOTAL_SHARES of 1e9 could lead to stuck funds for underlying tokens with lower decimals in the future
StrategyBase.sol#L28
uint96 internal constant MIN_NONZERO_TOTAL_SHARES = 1e9;
In the future, to support restaking and withdrawing tokens of lower decimals (USDC), MIN_NONZERO_TOTAL_SHARES could be changed to prevent funds from being locked. For example, 1e9 is equivalent to 1000 USDC which is a significant minimum amount to be locked in contract.
Recommendation: Could be complex since MIN_NONZERO_TOTAL_SHARES is the value to prevent ERC-4626 related inflation attacks
Some ways I can think of is setting a value for MIN_NONZERO_TOTAL_SHARES based on token decimals or implement logic to allow recovery of funds.
GalloDaSballo marked the issue as unsatisfactory:
Out of scope