code-423n4/2024-02-ai-arena-findings

QA Report

Opened this issue · 5 comments

c4-bot-5 commented

See the markdown file with the details of this report here.

raymondfam commented

L1/L8 to #1626

c4-pre-sort commented

raymondfam marked the issue as sufficient quality report

c4-judge commented

HickupHH3 marked the issue as grade-b

0xJuancito commented

Hi @HickupHH3.

Could you consider the following duplicates?

L-2 a duplicate of #116

It pinpoints the same impact:

This will make the player lose 0 points when they lose

But they will still earn points when they win

The same underlying issue:

curStakeAtRisk will be 0 when amountStaked[tokenId] + stakeAtRisk < 1000

With a slightly different recommendation, but with the same spirit of preventing unfair advantage of not losing points on losing (while earning on wins).

require(curStakeAtRisk > 0);

L-9 a duplicate of #1507

It pinpoints the same impact/underlying issue:

Roles can't be revoked

It has the same recommendation:

Assign admin roles, the DEFAULT_ADMIN_ROLE, or create specific functions to revoke roles for Neuron.sol