Consider adding disallowToken instead of only allowToken function
howlbot-integration opened this issue · 6 comments
Lines of code
https://github.com/code-423n4/2024-05-loop/blob/main/src/PrelaunchPoints.sol#L364
Vulnerability details
Impact
The absence of a disallowToken function in the "PrelaunchPoints" smart contract could potentially lead to various risks and limitations:
Inability to remove unsupported or problematic tokens from the contract's list of supported tokens.
Proof of Concept
/**
* @notice Disallows a token from being used within the contract
* @param _token The address of the token to disallow
* @dev Only the contract owner can call this function
*/
function disallowToken(address _token) external onlyAuthorized {
isTokenAllowed[_token] = false;
}Tools Used
Visual Studio Code
Recommended Mitigation Steps
Design the disallowToken function to allow the contract owner to remove specific tokens from the list of supported tokens.
Assessed type
Context
This poses a security risk in case of malicious owner, since disallowedTokens can be withdrawn by owner
koolexcrypto changed the severity to QA (Quality Assurance)
This previously downgraded issue has been upgraded by koolexcrypto
koolexcrypto marked the issue as primary issue
koolexcrypto marked the issue as unsatisfactory:
Invalid