code-charity/youtube

"Pause, while I'm typing" Search || comment || chat. "Pause while scrolled down"[same moment as custom miniplayer]

Opened this issue · 13 comments

ImprovedTube commented
  • "Pause while typing on youtube.com"
    and/or:
  • "Pause while the player isn't well visible" [same moment as custom miniplayer appears?]
  • "Pause for X seconds when leaving the tab, default: 8 seconds for a deep breath and focus on whatever makes us leave the tab"
  • "Pause while i type in any tab"
  • "Pause when i work fast in another tab (When there is a high keyboard and/or mouse/click-speed.) (requires all sites permission)
  • "Pause when inactive. And revert/skip back to where i might left.", for example in a visible youtube tab, after 80 seconds of HID inactivity, it could pause and skip back those 70 seconds (or a custom amount) - while inactivity could count soon (40 seconds?) when the video is playing in the background (or the viewport (=player) isn't visible, or playing as PiP.), While In full-screen mode (,cinema mode, and theater mode to some lesser extent), this feature might not be wanted since the user already decides to be inactive when entering full-screen mode, unless it would be smart like using webcam)

All of which might be structured as sub-options of auto-pause
All of which might have an exclusion such [when the video is music] (existing in our speed-watching feature)

gabrielhsdev commented

Hi @ImprovedTube

I noticed this open issue and I'm interested in tackling it. Can I take ownership of this and work on a solution? I believe I can contribute effectively to resolving it, I would love to start working on this issue as soon as possible

You can also contact me via: henriquegabrielhs21@gmail.com.

Thanks.

  • 🎉1
ImprovedTube commented

thank you so much! @gabrielhsdev

  • ❤️1
gabrielhsdev commented

Thanks, @ImprovedTube ! I'll dive into it as soon as possible ( I will start working on the tasks on May 5th ) . Quick question: Would it be acceptable to create a separate pull request for each of the five tasks? Appreciate your guidance in advance.

gabrielhsdev commented

Hi @ImprovedTube

I apologize for the delay in addressing this issue. Over the past month, I've been dealing with a challenging schedule due to university and work commitments.

I am now able to focus on this task and will start development immediately. I will provide updates on each feature as I progress.

Thank you for your patience and understanding. This comment is to update you on my current status.

Best regards.

gabrielhsdev commented

@ImprovedTube
Can you confirm I can still work on this task?
Thanks

Currently, I am developing these buttons:
image

  • 🎉1
  • ❤️1
  • 🚀1
gabrielhsdev commented

Hi @ImprovedTube

I hope you're doing well. I have just submitted a pull request for the first task on the list: "Pause while typing on youtube.com." When you have a moment, could you please review it?

#2336

Thank you for your time and consideration.

Updated Task List (I will update the checkboxes as I complete each task):

  • "Pause while typing on youtube.com"

  • "Pause while the player isn't well visible" [same moment as custom miniplayer]

  • "Pause for X seconds when leaving the tab, default: 8 seconds for a deep breath and focus on whatever makes us leave the tab"

  • "Pause while i type anything anywhere" - When playing in a background tab and the video is not music, but there is high keyboard or mouse speed. in any other tab such as writing a message with focus (requires all sites permission)

  • "Pause when inactive, and revert/skip back the whole way", for example after 70 seconds of HID inactivity, it can skip back 70 seconds (/- Xs customiseable amount?) - inactivity can count soon when the video is playing in the background, or the viewport (=player) isnt visible, or playing as PiP. If the video is visible normally or even in theater-mode inactivity can only be assumed later (unless we could measure if somebody is watching or not). In full-screen mode this feature cant apply (since the user already decides to be inactive when entering full-screen mode)

ImprovedTube commented

Hi! @gabrielhsdev

as I complete each task

Thank you for the intellectual fulfillment!
Was looking forward to somebody noticing the list! (besides that it is a first version, so of course it might still evolve.) Or at least there are nice related tasks/ideas already, that we might like to consider in advance already, like
#1565 2. Smart (combined) Key event-chain analysis (?)

(For this project it also is increasingly relevant, that we nest/sort/structure our toggles)

#2336: Didnt test yet. (starting with checking storage, it couldn't go wrong.)
(This could optionally also run in the existing keydown Eventlistener, thus not requiring it's own Eventlistener)

ImprovedTube commented

in what use-case might #2336 require the video to be visible?
(more powerful as an extra toggle)

gabrielhsdev commented

Hi @ImprovedTube

On my testing, the video may go back into playing in the background if the check of isPlayerInViewport is not there.

Steps for replicating ( without the isPlayerInViewport check )

  1. Activate the extension switch ( pause while typing on YouTube )

  2. Go to a YouTube video

  3. Give it a few seconds to play and load

  4. Click on the main YouTube page (YouTube icon on the navbar )
    image

  5. Waiting for everything to load

  6. Start typing on the search bar then stop ( do not search, hit enter, or anything ).

  7. The video loaded before going to the main YouTube page will resume playing, but just the audio. It is like the video plays on the background

gabrielhsdev commented

Hi! @gabrielhsdev

as I complete each task

Thank you for the intellectual fulfillment! Was looking forward to somebody noticing the list! (besides that it is a first version, so of course it might still evolve.) Or at least there are nice related tasks/ideas already, that we might like to consider in advance already, like #1565 2. Smart (combined) Key event-chain analysis (?)

(For this project it also is increasingly relevant, that we nest/sort/structure our toggles)

#2336: Didnt test yet. (starting with checking storage, it couldn't go wrong.) (This could optionally also run in the existing keydown Eventlistener, thus not requiring it's own Eventlistener)

Thank you for the feedback @ImprovedTube

I'm glad to have noticed the list and contributed to it. Here are my thoughts on the points you mentioned:

Task #1565: The smart (combined) key event-chain analysis sounds like a great addition. I can see how this could provide valuable insights. Once I finish developing the current issue, I'll look into this task and see how we can integrate it effectively.

Issue #2336: Noted on this. It’s good to know about the storage check and the potential for using the existing keydown Eventlistener to avoid redundancy.

I am actively working on and reviewing the tasks. I will submit my pull request next week after my university exams are finished.

  • 🎉1
  • ❤️1
  • 🚀1
ImprovedTube commented

hi @gabrielhsdev

Once I finish developing the current issue

...i think it is motivating to connect some dots - hopefully not to overwhelm or ask too much.

let me and us know everything you might have to share sooner or later!

( labeling as important/critical because of your wonderful participation & motivation.)
😀

gabrielhsdev commented

@ImprovedTube
I just got free from university as I'm now on vacation. This means I will have some more time to develop and focus on our project. Looking forward to contributing more and catching up on any pending tasks.

Thanks :)

  • 🎉1
  • ❤️1
  • 🚀1
ImprovedTube commented

hi! @gabrielhsdev
looking forward