code-kotis/react-floating-label

static properties misuse of colon instead of = ?

Opened this issue · 5 comments

niksosf commented

Hi there, I think the colon in
export default class FloatingLabel extends React.Component { static propTypes: {

is throwing error in babel. Is it also the case on your end? I am using web pack 2 with .babelrc like this
{ "presets": [ ["es2015", { "modules": false}], "react", "stage-0" ], "plugins": ["react-hot-loader/babel"] }

shouldn't it be static propTypes = {...}

kusakusakusa commented

I could get it to work by using babel-preset-stage-2.

niksosf commented

Well that's odd because stage 0 include stage 2

kusakusakusa commented

oh yes you're right. I've always thought that it is the other way round hahah

This is my .babelrc. Im using webpack 3 though.

{
  "presets": ["react", "es2015", "stage-2"],
  "env": {
    "development": {
      "presets": ["react-hmre"]
    }
  }
}
gokulkrishh commented

@VIC-L Thanks for helping out @niksosf 👍

joeyparis commented

I still get the same error when using @VIC-L's exact .babelrc configuration with Webpack 3.5.5.

I'm working on top of a react-boilerplate framework if that changes anything

It looks like react-boilerplate doesn't apply babel to files in node_modules. I was able to get it working by applying babel to the node_modules directory as well, but that drastically increased build time