codecov/codecov-bash

CI continues despite failure to release

Closed this issue · 8 comments

matthewberryman commented

Looks like something went wrong with your releasing step, as the current published bash script doesn't match the (github) released version; an assumption that your circleci orb relies on when validating the bash script against checksums. This then breaks all my usage of codecov, which relies on the orb.
More: codecov/codecov-circleci-orb#92

Tbilgere-td commented

Can confirm, Checksum stopped passing for us as well on multiple environments this evening.

matthewberryman commented

Digging a bit deeper:
This line in one of the CI scripts

codecov-bash/scripts/version.sh

Line 26 in c3ccd59

RELEASE_TAG=$(grep 'VERSION=\".*\"' codecov | cut -d'"' -f2)
relies on the version being updated in the bash script (it has not been in a while, despite changes) and the CircleCI ignores the git failure. This is because the exit status of version.sh is the exit status of the git push which works despite the tagging failure. https://app.circleci.com/pipelines/github/codecov/codecov-bash/410/workflows/1579b431-5c75-467c-8044-d6bdb5e0b00a/jobs/1140

  • 👍1
thomasrockhu commented

Hi all, I have made the change on our end and deployed 1.0.4. Please let me know if you are still experiencing the issue. It should be live within an hour.

Tbilgere-td commented

Hi all, I have made the change on our end and deployed 1.0.4. Please let me know if you are still experiencing the issue. It should be live within an hour.

Hey, just attempted a build and it appears the file at https://codecov.io/bash is still 1.0.3 and still does not pass checksum. Perhaps something to do with the 1.0.4 release not including the necessary assets?

  • 👍2
jpeach commented

Hi all, I have made the change on our end and deployed 1.0.4. Please let me know if you are still experiencing the issue. It should be live within an hour.

Hey, just attempted a build and it appears the file at https://codecov.io/bash is still 1.0.3 and still does not pass checksum. Perhaps something to do with the 1.0.4 release not including the necessary assets?

Confirmed that this is still broken.

$ curl -s -L https://codecov.io/bash | grep ^VERSION=
VERSION="1.0.3"

Since this problem is breaking CI for projects, is there a time frame for fixing it?

ouranos commented

Yes, still broken, had the issue this morning: #449

thomasrockhu commented

Hi all, I made a fix in the deployment, it should be showing 1.0.4 now.

jpeach commented

Hi all, I made a fix in the deployment, it should be showing 1.0.4 now.

Verified that this works in our CI. Thanks @thomasrockhu 💯

  • ❤️1