Coverage doesn't load on Firefox
Closed this issue · 13 comments
I'm trying to use the Firefox addon but the coverage doesn't load. I see "Loading coverage report..." on the page, but that's it. Checking the Network tab, I see that drop.min.js tries to load from Cloudflare, but is blocked due to CSP.
Addon version 0.2.0, Firefox 113.0.2 (64-bit), Ventura (13.4). uBlock is disabled on Github.
Thanks for letting us know, we don't see this issue in Chrome, but can reproduce in firefox. So we will work on this and get a fix out in our next release.
@bmulholland I believe we've shipped an update that we think may address this problem. Are you still seeing issues?
Yes, same issue. Now there's no network request in devtools Network tab, but console does show "Error: NetworkError when attempting to fetch resource." No other info is output. There is no attempt to connect to CodeCov in the Network tab. Addon version 0.2.1
Experienced same as @bmulholland on 0.2.1, also on Firefox 113.0.2 (64-bit) =)
What I noticed afterwards is that there was an unset permission in the extension settings for "Access your data for https://api.codecov.io". After enabling, it changed from "Loading coverage report" to "Coverage report not available" and no longer had the network error
Also seeing the below white space for preferences but that might be unrelated!
Oh nice find. I can confirm I never saw a prompt for that, and that after enabling that option I also see "report not available." I still don't see any requests to Codecov in the Network tab of devtools.
Okay actually that looks to be happening because Codecov isn't actually receiving my coverage at all. It's saying we're throttled because we're on a free plan (though we're actually paying...). It's also silently failing in CI. Not cool. Will write support.
I'm not sure what ye changed over the last few hours but it's now working for me so thanks =)
What I noticed afterwards is that there was an unset permission in the extension settings for "Access your data for https://api.codecov.io/". After enabling, it changed from "Loading coverage report" to "Coverage report not available" and no longer had the network error
Both these permissions are actually specified as required, so it's very strange that they don't show up during installation and instead here under optional permissions.
I can reproduce this locally, and also see a (old) comment on Mozilla Bugzilla that mentions this bug, so will do some more digging to find the root cause.
I got the issue with my Codecov license resolved and can now see coverage report stats on PRs. I don't see inline coverage indicators though, is that supposed to work?
@bmulholland are you a dark mode user? I'm noticing that I do not get PR line coverage in dark mode. We're currently discussing this in #26
Issue appears to be resolved, inline coverage indicators on PR issue is tracked in #26, so we will be closing this.
Thank you! No, I'm not a dark mode user.
@eliatcodecov No, it was not fixed, #50 shows it and I just had it now fresh too.