codefactor-io/codefactor

Are ESLint custom configs supported?

tomcastro opened this issue · 1 comments

Hi everyone!

We are trying out Codefactor for our organization and it works great so far.

Our only problem comes from having a custom ESLint configurations:

image

Our .eslintrc.json file:

{
  "parser": "@typescript-eslint/parser",
  "extends": [
    "rokket-labs",
    "rokket-labs/react",
    "eslint:recommended",
    "plugin:@typescript-eslint/recommended",
    "prettier/@typescript-eslint"
  ],
  "settings": {
    "react": {
      "version": "detect"
    }
  },
  "env": {
    "browser": true,
    "node": true,
    "es6": true
  },
  "plugins": ["@typescript-eslint", "react"],
  "parserOptions": {
    "ecmaFeatures": {
      "jsx": true
    },
    "ecmaVersion": 2018,
    "sourceType": "module"
  },
  "rules": {
    "react/prop-types": "off",
    "@typescript-eslint/explicit-function-return-type": "off",
    "no-use-before-define": "off",
    "@typescript-eslint/no-use-before-define": ["error"]
  },
  "overrides": [
    {
      "files": ["*.js"],
      "rules": {
        "@typescript-eslint/no-var-requires": "off"
      }
    }
  ]
}

The error reads out not supported dependencies: rokket-labs. Here's our custom config.

Is this kind of configuration supported? I'm pretty sure we're not using any plugins outside of the ones specified here.

@tomcastro thanks for reaching out. Yes, such configuration are supported. You should now see proper results for your repo.