codegangsta/inject

i think parent of injector should be pointer

Closed this issue · 2 comments

win-t commented
type Injector interface {
    Applicator
    Invoker
    TypeMapper
    // SetParent sets the parent of the injector. If the injector cannot find a
    // dependency in its Type map it will check its parent before returning an
    // error.
    SetParent(*Injector) // <-- we need reference to parent, not a copy of parent
}

what do you think?

win-t commented

forget it, i made mistake,

just use parent's method, not share any variables, so it is not nessisary.