Optional URLs on items

Question

Optional URLs on items

Closed this issue 13 years ago · 5 comments

I think the navigation should support items without links (imagine a tree structure, where you can only access leafs).

Answer 1 · 2011-09-08T09:33:18.000Z

Please see the 'linkless-items' branch and see if this works for you.

Answer 2 · 2011-09-08T10:14:58.000Z

Nice. Thank you! Tested it, but I think it'll need some improvements. I think it shouldn't render the a tag, just normal text (or maybe spaned. Also, the method should not need the url argument, but could specify it:

primary.item :justtext, 'Just text'
primary.item :justtext1, 'Just text', nil
primary.item :linkswork, 'Click me!', url

Could it be possible?

Answer 3 · 2011-09-21T14:21:18.000Z

+1 for implementing this feature

Answer 4 · 2011-10-10T12:11:56.000Z

me too. would like link to be optional

Answer 5 · 2011-12-03T23:12:10.000Z

Hello Francisco (and +1ers!),

I've done some more work on this feature and merged into master. Just released as 3.6.0, hope it's good for you all.

The URL parameter is now optional as you requested - it is still possible to specify options without specifiying the URL (ie. you aren't forced to specify nil when wanting to specify options) as a Hash at that parameter position is interpreted as options rather than a URL. I think this provides the most flexibility and appropriate expressiveness within the DSL.

If you have any further suggestions, please don't hesitate to let me know and I'll work on them in a future release.

Cheers,

Mark.