Attempt to reconnect when coder sh disconnects randomly
wbobeirne opened this issue · 4 comments
This is by far my biggest annoyance with coder sh, I get disconnected quite frequently. Could we attempt to reconnect for a second or two before dumping the user back to their terminal?
The issue is made even more annoying by #51 since it still looks like you're in your terminal if you're running tmux or some such.
Yeah, this is definitely incredibly annoying. The trouble I'm having here is how to balance preventing process/connection leakage with a useful reconnection UX. Ideally, I'd like to solve the root of the disconnect problem but that has proved itself to be very difficult.
A hacky solution could be that we reconnect and just create a new terminal session? @wbobeirne any thoughts on that?
Hmm, I guess if the terminal session is lost, reconnecting might give the user the wrong impression if they expect everything to be as it was. I'd say if it has to be a new session, then we're probably better off with the explicit kill.
We've fixed many of the disconnect conditions that were causing this. And now that we use ssh directly there isn't much for us to do in this arena.