coder/websocket

Support (*http.ResponseController).Hijack()

gz-95 opened this issue · 1 comments

gz-95 commented

Currently the library checks http.ResponseWriter for http.Hijacker support via type assertion.

Is there a possibility we can use (*http.ResponseController).Hijack() instead? This way we can support http.ResponseWriter types that don't offer http.Hijacker interface but their underlying unwrapped writers do.

Thanks for bringing this up, we'll have to update the minimum Go version to 1.20 or make an exception for 1.19, but this seems like a reasonable request 👍🏻.