coderaiser/node-grizzly

ability to mark release as a pre-release

Closed this issue · 6 comments

davelandry commented
ability to mark release as a pre-release
coderaiser commented

What do you mean by pre-release? Is it specific prefix for tags?

davelandry commented

For example, I have been marking the < 1.0 releases of my repositories as "pre-release": https://github.com/d3plus/d3plus-text/releases. You see it as a checkbox when creating release notes through the web interface.

Looks like it's part of the createRelease payload as a Boolean: https://developer.github.com/v3/repos/releases/#create-a-release

I feel pretty comfortable creating a pull request, would it just be as simple as passing another argument here? https://github.com/coderaiser/node-grizzly/blob/master/lib/release.js#L45

Was thinking:

prerelease: options.prerelease || false,
coderaiser commented

Yes, it would be great. Place you mentioned is right one, but there is a few more:
bin and global part of docs, and example part of docs.

coderaiser commented

@davelandry any progress with this?

davelandry commented

I haven't had a chance to do this yet, and probably won't until next week at the earliest.

davelandry commented

@coderaiser nevermind, I'm going to do this right now. get ready for the pull request!