coderofsalvation/powscript

Powscript in `--sh` mode includes bash settings

fcard opened this issue · 1 comments

fcard commented

While trying to fix the tests, I encountered this problem. Since shopt -s extglob, BASH_SOURCE etc aren't Bourne Shell compatible, that's not gonna work.

Would this be an acceptable solution?

  1. move the settings=(<lang/bash/.settings) from .tools/compile to src/powscript.bash
  2. change it to settings=(<lang/$runtime/.settings)
  3. create a separate lang/sh/.settings file.

Edit: No, that wouldn't work because it would cause a dependency on a ".settings" file in the final powscript file. I will figure something out. (or if you have a suggestion... :P)

fcard commented

I got it, will submit a PR soon for review.