coding-blocks/gondor

app menu section does not scroll on mobile

Closed this issue ยท 15 comments

When the app menu and team members section is below Calendar. The window does not scroll over the app menu and team members section.

Thanks @samagragupta, for raising the issue! ๐Ÿ™Œ

One of our mentors will revert on this soon. โœ…

Star โญ this project and tweet ๐Ÿฆ about BOSS 2020.

Add loom recording or gif.

@hereisnaman
abc

@hereisnaman, would like to work if @samagragupta not working.

@jugshaurya I am working on that.

@samagragupta how are you trying to solve this issue?

@samagragupta @hereisnaman,I think simply adding a height of 100vh to scroll menu can solve this. I tried and it works

@samagragupta @hereisnaman,I think simply adding a height of 100vh to scroll menu can solve this. I tried and it works

How will 100vh work for desktop? Please share a gif.

@samagragupta @hereisnaman, I think simply adding a height of 100vh to scroll menu can solve this. I tried and it works

How will 100vh work for desktop? Please share a gif.

@hereisnaman, sorry my bad: max-height: 100vh can solve this. here is how:

a

@samagragupta @hereisnaman, I think simply adding a height of 100vh to scroll menu can solve this. I tried and it works

How will 100vh work for desktop? Please share a gif.

@hereisnaman, sorry my bad: max-height: 100vh can solve this. here is how:

a

Go ahead, create a PR.

@hereisnaman @jugshaurya From that we can scroll the team members section only. We cannot scroll the window.
I think we can also wheelPropagation true so that it can also scroll the window.
Should I make a PR @hereisnaman
Like this:
213

@samagragupta no I dont think scroll window is going to be a problem. try adding the main section again (just for testing). we can scroll the window. I don't think there is a problem with that.
countr

@samagragupta @jugshaurya Lets discuss both the implementations in detail. You both raise the PR.

I think enabling wheel propagation will be better. I'll compare them locally once both the PRs are raised.

@hereisnaman please review

@samagragupta @jugshaurya Lets discuss both the implementations in detail. You both raise the PR.

I think enabling wheel propagation will be better. I'll compare them locally once both the PRs are raised.

Okay, I will create the PR with my implementation.