disable static by default (again)
svigerske opened this issue · 5 comments
Issue created by migration from Trac.
Original creator: @svigerske
Original creation time: 2018-10-20 01:23:15
Assignee: @svigerske
Keywords: autotools-update
I think I might disable static builds by default again (though I want to see the effect of #98 first).
Further, on Windows I'll forbid doing a shared and a static build concurrently. The reason is that the config header file (or the CFLAGS in the .pc file) will be different when using shared or static libs, because when linking against a shared lib (DLL), one needs to make sure that __declspec(dllimport) is active in the header files. This is easiest to achieve if one builds only one variant of the libs. Maybe it will also help to work around some of the libtool bugs mentioned in #112 (comments 5 and 6).
Comment by @svigerske created at 2018-10-21 21:52:43
Disabled static with 5244d13.
Comment by @tkralphs created at 2018-10-29 16:10:57
The implications of this are not really clear to me. with --enable-debug, would we still have static libraries?
Comment by @svigerske created at 2018-10-29 16:17:39
--enable-debug is actually not there at the moment. But if and when it comes back, then it would not also change to static libs. You would need to set --disable-shared additionally.
One could argue that this is not unintuitive behavior.
Comment by @svigerske created at 2018-11-24 13:54:55
Added giving an error if --enable-static is given on Windows/(i)cl without --disable-shared with 4add928.
Comment by @svigerske created at 2018-11-24 13:54:55
Resolution: fixed