make lint fails
Closed this issue · 3 comments
sidhujag commented
I ran make lint on the latest master and saw this:
node.go:46:14: wrapperFunc: use strings.ReplaceAll method in strings.Replace(str, "\n", "", -1) (gocritic) message := strings.Replace(str, "\n", "", -1
patrick-ogrady commented
Which version of golangci-lint are you using? master is currently running v1.30.0:
Currently passing (not sure if you can see this page): https://app.circleci.com/pipelines/github/coinbase/rosetta-bitcoin/119/workflows/80e0fb94-d5fc-4e38-914c-4605eb1f7bc8/jobs/729
sidhujag commented
yea that might be it, I'm on 1.32.2
patrick-ogrady commented
Oof we're behind...I'd be happy to review a PR that updates it and fixes any linting issues!