cole14/rust-elf

Implement ReadBytesAt for owned CachedReadBytes

pjht opened this issue · 3 comments

pjht commented

Right now, ReadBytesAt is only implemented for a mutable reference to a CachedReadBytes. This requires an extra variable to hold the CachedReadBytes instead of passing it directly to File::open_stream. Ideally, ReadBytesAt would also be implemented for an owned CachedReadBytes, allowing it to be passed directly.

Thanks for the suggestion, what do you think of #22?

pjht commented

Looks good, that would accomplish what I wanted.

Cool. I bundled this change into crate v0.4.0.