coli-saar/alto

asConcreteAutomatonBottomUp is broken

Closed this issue · 2 comments

akoehn commented

Original report by Christoph Teichmann (Bitbucket: cteichmann, GitHub: CTNLP).

In TreeAutomaton.asConcreteAutomatonBottomUp the two lines:

processAllRulesBottomUp(rule -> ret.addRule(ret.createRule(getStateForId(rule.getParent()), rule.getLabel(this), getStatesFromIds(rule.getChildren()))));
finalStates.stream().forEach(finalState -> ret.addFinalState(finalState));

are wrong. The final states are only added correctly, if the new automaton numbers the states in the same way that the old automaton does (not guaranteed). For the rules, the weight is not copied.

akoehn commented

Original comment by Christoph Teichmann (Bitbucket: cteichmann, GitHub: CTNLP).

Has been fixed with the most recent change.

akoehn commented

Original changes by Christoph Teichmann (Bitbucket: cteichmann, GitHub: CTNLP).

changed state from "new" to "closed"