static serving from resources after assembly fails

[siddhartha-gadgil]

In https://github.com/siddhartha-gadgil/MillScalaServer (and also a larger project, which is what I wanted), serving from resources works fine with server.run and server.runBackgroundbut fails on running the result of server.assembly

• Even files in the resources folder behave the same way.

[siddhartha-gadgil]

In the following code in cask, relPath is defined but not used.

val relPath = java.nio.file.Paths.get(path)
    val (data0, statusCode0) = resourceRoot.getResourceAsStream(path) match{
      case null => ("": Response.Data, 404)
      case res => (res: Response.Data, 200)
    }

is that a typo (which accidentally does not matter in run)?

[lihaoyi]

It seems to work fine with the example project:

  @cask.staticResources("/static/resource")
  def staticResourceRoutes() = "cask"

Perhaps it's something to do with the way your app has

  @cask.staticResources("/public")
  def staticResourceRoutes() = "."

?

Not sure what "." means w.r.t. JVM resources, but maybe it doesn't like it in some cases

[siddhartha-gadgil]

I had tried "" (empty) which failed and "." worked. I'll see what happens if I move my resources.

…

On Sat, Aug 25, 2018 at 2:50 PM Li Haoyi ***@***.***> wrote: It seems to work fine with the example project: @cask.staticResources("/static/resource") def staticResourceRoutes() = "cask" Perhaps it's something to do with the way your app has @cask.staticResources("/public") def staticResourceRoutes() = "." ? Not sure what "." means w.r.t. JVM resources, but maybe it doesn't like it in some cases — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADatpBxmUtNAtLCz3KBuVgMfMiYhC804ks5uURbFgaJpZM4WI3Eu> .

[lihaoyi]

might be fixed in 4369a2f

[siddhartha-gadgil]

Is there a way to refer to this in mill?

…

On Sat, Aug 25, 2018 at 3:23 PM Li Haoyi ***@***.***> wrote: might be fixed in 4369a2f <4369a2f> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADatpHjVITtZzwrGyPo1F8nc_Dcq3d_Hks5uUR6cgaJpZM4WI3Eu> .

[Ammonite-Bot]

try updating the Cask version to 0.1.6 On Sat, 25 Aug 2018 at 6:28 PM, Siddhartha Gadgil <notifications@github.com> wrote:

…

Is there a way to refer to this in mill? On Sat, Aug 25, 2018 at 3:23 PM Li Haoyi ***@***.***> wrote: > might be fixed in 4369a2f > < 4369a2f > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#4 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/ADatpHjVITtZzwrGyPo1F8nc_Dcq3d_Hks5uUR6cgaJpZM4WI3Eu > > . > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATpwjOXqwIvRNMvYX8gltNgEDC-UOSwIks5uUSbCgaJpZM4WI3Eu> .

[siddhartha-gadgil]

Fixed in the toy project. Thanks a lot.
I'll confirm in the larger project and close

[siddhartha-gadgil]

It is indeed fixed. Thanks again.

[efim]

For anyone who gets here with similar problem:

I had errors 404 with server not being able to locate images by path that should have worked
that turned out to be a problem with browser - it was caching 404 from builds that were incorrect
i've been able troubleshoot that by not trusting initial 404 responses, and manually triggering "Resend" in the Network console

And before that i checked "jar tf stripe-0.0.1-SNAPSHOT.jar | grep public" to see if my 'public' dir is indeed in the assembly jar

Overall the function works as should be expected
'src/main/resources' is root, and for example to server 'src/main/resources/public' the method should return "public"