Removing Settings mixin and use `.nsdUploadButton` prop
juancho0202 opened this issue · 2 comments
Related to #306
Currently the Settings Mixin in the compas-open-scd package is a slightly modified version of the Settings mixin in the open-scd package with the sole difference of removing the lines that allow users to load custom nsdoc files.
OpenSCD already features a way to disable that button via a prop https://github.com/openscd/open-scd/blob/56cc548de4311dd7a0c92bd514d313896b08482f/packages/open-scd/src/addons/Settings.ts#L116C3-L116C18
Acceptance criteria:
- The settings mixin is removed from compas-open-scd
- We pass down to the
<open-scd>tag a prop called nsdUploadButton = false
On hold until #324 (Update compas-open-scd with the latest version of open-scd) is done
Hello there,
Thank you for opening this issue! We appreciate your interest in our project.
However, it seems that this issue hasn't had any activity for a while. To ensure that our issue tracker remains organized and efficient, we occasionally review and address stale issues.
If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better.
Feel free to continue the conversation here.
If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later.
Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve.
Thank you for being part of this journey!