comby-tools/comby

comby 1.8.1 failed to build against ocaml 5.0.0

chenrui333 opened this issue · 4 comments

while trying to ocaml to 5.0.0, found an issue while regression build comby 1.8.1

⬇ retrieved ocaml-variants.4.12.0+domains  (git+https://github.com/ocaml-multicore/ocaml-multicore.git#4.12+domains)
[ERROR] The compilation of ocaml-variants.4.12.0+domains failed at "make -j9".

#=== ERROR while compiling ocaml-variants.4.12.0+domains ======================#
# context              2.1.4 | macos/arm64 |  | https://opam.ocaml.org#0fd96b90
# path                 /private/tmp/comby-20230219-29540-15z8nt/comby-1.8.1/.opam/default/.opam-switch/build/ocaml-variants.4.12.0+domains
# command              /opt/homebrew/Library/Homebrew/shims/mac/super/make -j9
# exit-code            2
# env-file             /private/tmp/comby-20230219-29540-15z8nt/comby-1.8.1/.opam/log/ocaml-variants-30048-4d85a2.env
# output-file          /private/tmp/comby-20230219-29540-15z8nt/comby-1.8.1/.opam/log/ocaml-variants-30048-4d85a2.out
### output ###
# [...]
# cc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Wdeclaration-after-statement -fno-common -g  -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE   -DCAMLDLLIMPORT= -DNATIVE_CODE -DTARGET_arm64 -DMODEL_default -DSYS_macosx   -o clambda_checks.n.o clambda_checks.c
# cc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Wdeclaration-after-statement -fno-common -g  -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE   -DCAMLDLLIMPORT= -DNATIVE_CODE -DTARGET_arm64 -DMODEL_default -DSYS_macosx   -o afl.n.o afl.c
# cc -c -O2 -fno-strict-aliasing -fwrapv -Wall -Wdeclaration-after-statement -fno-common -g  -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DCAML_NAME_SPACE   -DCAMLDLLIMPORT= -DNATIVE_CODE -DTARGET_arm64 -DMODEL_default -DSYS_macosx   -o bigarray.n.o bigarray.c
# fiber.c:233:53: error: use of undeclared identifier 'Wosize_gc_regs'
#     value* bucket = caml_stat_alloc(sizeof(value) * Wosize_gc_regs);
#                                                     ^
# 1 error generated.

thanks @chenrui333! I'll have to tweak the build commands for 5.0.0 since it's a major bump. We'll track progress with this issue.

@rvantonder hope everything goes well, any updates on this thread? Thanks!

relates to Homebrew/homebrew-core#154837

Thanks for the ping @chenrui333 let me see what I can do!